[389-commits] ldap/servers

ldap/servers/plugins/passthru/ptpreop.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 4c66307c88d74ada36ebdbcfca4b97b1d71fd93b
Author: William Brown <firstyear@redhat.com>
Date: Fri Apr 22 12:12:59 2016 +1000

Ticket 48801 - ASAN errors during tests

Bug Description: ERROR: AddressSanitizer: stack-buffer-overflow was detected
during the stress tests of DS

Fix Description: passthru auth was using an int rather than a ber_tag_t for
the pointer into slapi_pblock_get causing a buffer overflow.

https://fedorahosted.org/389/ticket/48801

Author: wibrown

Review by: nhosoi

diff --git a/ldap/servers/plugins/passthru/ptpreop.c b/ldap/servers/plugins/passthru/ptpreop.c
index 1fc8b1f..95b3b33 100644
--- a/ldap/servers/plugins/passthru/ptpreop.c
+++ b/ldap/servers/plugins/passthru/ptpreop.c
@@ -120,7 +120,8 @@ passthru_bindpreop_close( Slapi_PBlock *pb )
static int
passthru_bindpreop( Slapi_PBlock *pb )
{
- int rc, method, freeresctrls=1;
+ int rc, freeresctrls=1;
+ ber_tag_t method = 0;
char *matcheddn;
const char *normbinddn = NULL;
Slapi_DN *sdn = NULL;

--
389-commits mailing list
389-commits@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/389-commits@lists.fedoraproject.org