[389-devel] Re: Please review, svrcore fix coverity issues 6 through 10

On Tue, 2016-04-12 at 11:06 -0700, Noriko Hosoi wrote:
> On 04/11/2016 10:30 PM, William Brown wrote:
> >
> > https://pagure.io/svrcore/pull-request/11
> >
> > Patch bundle to fix coverity issues discovered during build processes.
> >
> >
> >
> > --
> > 389-devel mailing list
> > 389-devel@%(host_name)s
> > http://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject.org
> Maybe, it'd be nice to give us this link, too.  (First, I was not sure 
> what to review... :)
>
>     https://pagure.io/svrcore/pull-request/11.patch

I will do that next time. I have update this request now.

>
> The patch page does not provide the nice coloring as on 389 trac. Could 
> there be any way to configure it (well, that'd be a question to myself, 
> though)?  Until we figure it out, could you please attach the patch to 
> the original trac ticket 389ds #48450?

I'm not sure how to change this sorry. 

>
> I have some questions on the patches...

I have fixed all these issues, plus some extras. I have rebased, and force-pushed
to pagure for review. 


--
Sincerely,

William Brown
Software Engineer
Red Hat, Brisbane