[389-devel] Discussion: rpm changes

Hi,

Looking in the rpm I noticed a few things:

%preun
if [ $1 -eq 0 ]; then # Final removal
# remove instance specific service files/links
rm -rf %{_sysconfdir}/systemd/system/%{groupname}.wants/*
> /dev/null 2>&1 || :
fi


I don't actually think we need this. If we un-install, the instance
configuration and data dirs will remain. So if someone un-installs and
re-installs, this will break their instances.

Because we remove the dirsrv.target unit file, leaving the
dirsrv.target.wants is probably okay, so we can remove the %preun I
think.

%postun
/sbin/ldconfig
if [ $1 = 0 ]; then # Final removal
rm -rf /var/run/%{pkgname}
fi


Similar comment here. I think we can make this:

%postun -p /sbin/ldconfig

Does that sound reasonable?


--
Sincerely,

William Brown
Software Engineer
Red Hat, Brisbane