Monday, February 12, 2018

[389-commits] [389-ds-base] 01/01: Ticket 49551 - fix memory leak found by coverity

This is an automated email from the git hooks/post-receive script.

lkrispen pushed a commit to branch 389-ds-base-1.3.7
in repository 389-ds-base.

commit c1183e529e6dd52aa947fbbe321950bacae3f47e
Author: Ludwig Krispenz <lkrispen@redhat.com>
Date: Mon Feb 12 16:27:03 2018 +0100

Ticket 49551 - fix memory leak found by coverity
---
ldap/servers/plugins/replication/repl5_replica.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/ldap/servers/plugins/replication/repl5_replica.c b/ldap/servers/plugins/replication/repl5_replica.c
index 31d3b37..c6d6ee7 100644
--- a/ldap/servers/plugins/replication/repl5_replica.c
+++ b/ldap/servers/plugins/replication/repl5_replica.c
@@ -3001,6 +3001,7 @@ process_reap_entry(Slapi_Entry *entry, void *cb_data)
if the value is set in the replica, we will know about it immediately */
PRBool *tombstone_reap_stop = ((reap_callback_data *)cb_data)->tombstone_reap_stop;
const CSN *deletion_csn = NULL;
+ int deletion_csn_free = 0;
int rc = -1;

/* abort reaping if we've been told to stop or we're shutting down */
@@ -3023,6 +3024,7 @@ process_reap_entry(Slapi_Entry *entry, void *cb_data)
char *tombstonecsn = slapi_entry_attr_get_charptr(entry, SLAPI_ATTR_TOMBSTONE_CSN);
if (tombstonecsn) {
deletion_csn = csn_new_by_string(tombstonecsn);
+ deletion_csn_free = 1;
slapi_ch_free_string(&tombstonecsn);
}
}
@@ -3055,6 +3057,9 @@ process_reap_entry(Slapi_Entry *entry, void *cb_data)
/* Don't update the count for the database tombstone entry */
(*num_entriesp)++;
}
+ if (deletion_csn_free) {
+ csn_free(&deletion_csn);
+ }

return 0;
}

--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
_______________________________________________
389-commits mailing list -- 389-commits@lists.fedoraproject.org
To unsubscribe send an email to 389-commits-leave@lists.fedoraproject.org

No comments:

Post a Comment