On 4/3/19 9:01 AM, Ludwig Krispenz wrote:
> Hi,
> added some small comments, but it is overall ok.
I'll review them shortly :-)
>
> Just thinking about it, wouldn't it be an option that the task entry
> survives until it is completed and written to the dse.ldif at
> shutdown, so at startup tasks could be resumed from the task entry not
> from params in the repl entry ?
I like the idea, but I don't know if the server will. I ran into
"timing" issues just trying to add the task during plugin startup. I'm
worried that when we process dse.ldif it might be too soon to start a
task. Either way, it's a good idea and it can remove my hacky code and
allow us to cleanup some of the cleanAllRUV code too, so I'm going to
try it! I'll add a "nsTaskPersist" attribute to the task, etc...
Thanks,
Mark
>
> Ludwig
>
> On 04/03/2019 02:27 PM, Mark Reynolds wrote:
>> Friendly reminder :-)
>>
>>
>> https://pagure.io/389-ds-base/pull-request/50307
>> _______________________________________________
>> _______________________________________________
>> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
>> To unsubscribe send an email to 389-devel-leave@lists.fedoraproject.org
>> Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
>> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>> List Archives:
>> https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org
>
_______________________________________________
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-leave@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org
No comments:
Post a Comment