[389-commits] [389-ds-base] branch 389-ds-base-1.3.9 updated: Ticket 50428 - Log the actual base DN when the search fails with "invalid attribute request"

This is an automated email from the git hooks/post-receive script.

tbordaz pushed a commit to branch 389-ds-base-1.3.9
in repository 389-ds-base.

The following commit(s) were added to refs/heads/389-ds-base-1.3.9 by this push:
new f00f35c Ticket 50428 - Log the actual base DN when the search fails with "invalid attribute request"
f00f35c is described below

commit f00f35c43fc5cd23ebd21bd0bddd005679c73b11
Author: Thierry Bordaz <tbordaz@redhat.com>
AuthorDate: Fri Jun 7 11:35:46 2019 +0200

Ticket 50428 - Log the actual base DN when the search fails with "invalid attribute request"

Bug Description:
When a search request contains invalid parameters (attribute list with empty attribute
name, unknown scope, invalid filter..) the search is rejected but the access log
contains a wrong base search: ... SRCH base="(null)"...
This is because it does not use for logging the variable that gather the actual base ('rawbase')

Fix Description:
Use 'rawbase' value for logging

https://pagure.io/389-ds-base/issue/50428

Reviewed by: Mark Reynolds

Platforms tested: F28

Flag Day: no

Doc impact: no
---
ldap/servers/slapd/search.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/ldap/servers/slapd/search.c b/ldap/servers/slapd/search.c
index 7e253f5..2a99795 100644
--- a/ldap/servers/slapd/search.c
+++ b/ldap/servers/slapd/search.c
@@ -154,6 +154,7 @@ do_search(Slapi_PBlock *pb)
goto free_and_return;
}
}
+ base = rawbase;

/*
* ignore negative time and size limits since they make no sense

--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
_______________________________________________
389-commits mailing list -- 389-commits@lists.fedoraproject.org
To unsubscribe send an email to 389-commits-leave@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/389-commits@lists.fedoraproject.org