Friday, April 3, 2020

[389-commits] [389-ds-base] branch 389-ds-base-1.4.1 updated: Issue 50952 - SSCA lacks basicConstraint:CA

This is an automated email from the git hooks/post-receive script.

vashirov pushed a commit to branch 389-ds-base-1.4.1
in repository 389-ds-base.

The following commit(s) were added to refs/heads/389-ds-base-1.4.1 by this push:
new c4e7736 Issue 50952 - SSCA lacks basicConstraint:CA
c4e7736 is described below

commit c4e7736544ce0dc92b33a48bcee6285e1e16a281
Author: Viktor Ashirov <vashirov@redhat.com>
AuthorDate: Fri Apr 3 14:41:00 2020 +0200

Issue 50952 - SSCA lacks basicConstraint:CA

Bug Description:
`capture_output` was introduced in python 3.7 and
on earlier versions this code produces TypeError.

Fix Description:
Make it compatible with python 3.6 by setting `stderr`
and `stdout` to PIPE.

Fixes: https://pagure.io/389-ds-base/issue/50952

Reviewed by: mhonek (Thanks!)
---
src/lib389/lib389/nss_ssl.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/lib389/lib389/nss_ssl.py b/src/lib389/lib389/nss_ssl.py
index 9c5b972..e48b78f 100644
--- a/src/lib389/lib389/nss_ssl.py
+++ b/src/lib389/lib389/nss_ssl.py
@@ -19,7 +19,7 @@ import logging
# from nss import nss
import subprocess
from datetime import datetime, timedelta, date
-from subprocess import check_output, run
+from subprocess import check_output, run, PIPE
from lib389.passwd import password_generate
from lib389.lint import DSCERTLE0001, DSCERTLE0002
from lib389.utils import ensure_str, format_cmd_list
@@ -254,7 +254,7 @@ only.
]
cmd_input = b'y\n\n' # responses to certutil questions
self.log.debug("nss cmd: %s", format_cmd_list(cmd))
- result = ensure_str(run(cmd, check=True, capture_output=True, input=cmd_input).stdout)
+ result = ensure_str(run(cmd, check=True, stderr=PIPE, stdout=PIPE, input=cmd_input).stdout)
self.log.debug("nss output: %s", result)
# Now extract the CAcert to a well know place.
# This allows us to point the cacert dir here and it "just works"

--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
_______________________________________________
389-commits mailing list -- 389-commits@lists.fedoraproject.org
To unsubscribe send an email to 389-commits-leave@lists.fedoraproject.org
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/389-commits@lists.fedoraproject.org

No comments:

Post a Comment