[fedora-arm] Re: [Call for Action] Help Testing F39 ARM

On Thu, 2023-10-26 at 16:50 +0200, Peter Boy wrote:
>
> > Am 26.10.2023 um 15:30 schrieb Frantisek Zatloukal <fzatlouk@redhat.com>:
> >
> > With rpi4, I didn't hit any issues:
> >
> > $ sudo fedora-arm-image-installer --image=Fedora-Workstation-39-1.2.aarch64.raw.xz --norootpass --media=/dev/sda
> > Place your finger on the fingerprint reader
> > Failed to match fingerprint
> > Place your finger on the fingerprint reader
> >
> > =====================================================
> > = Selected Image:
> > = Fedora-Workstation-39-1.2.aarch64.raw.xz
> > = Selected Media : /dev/sda
> > = Root Password will be removed.
> > =====================================================
> >
> > *****************************************************
> > *****************************************************
> > ******** WARNING! ALL DATA WILL BE DESTROYED ********
> > *****************************************************
> > *****************************************************
> >
> > Type 'YES' to proceed, anything else to exit now
> >
> > = Proceed? yes
> > GPT PMBR size mismatch (4156811 != 250085375) will be corrected by write.
> > The backup GPT table is corrupt, but the primary appears OK, so that will be used.
> > The backup GPT table is not on the end of the device.
> > = Writing:
> > = Fedora-Workstation-39-1.2.aarch64.raw.xz
> > = To: /dev/sda ....
> > dd: warning: partial read (65536 bytes); suggest iflag=fullblock
> > 17014218752 bytes (17 GB, 16 GiB) copied, 213 s, 79.9 MB/s17179869184 bytes (17 GB, 16 GiB) copied, 213.812 s, 80.4 MB/s
> >
> > 0+619058 records in
> > 0+619058 records out
> > 17179869184 bytes (17 GB, 16 GiB) copied, 213.818 s, 80.3 MB/s
> > = Writing image complete!
> > = No U-boot will be written.
> > = Removing the root password.
> >
> > = Installation Complete! Insert into the board and boot.
> >
>
> Well, if you look at the source, you'll see the issue is in line 543:
>
> > = Writing image complete!
> > mount: /tmp/root: unknown filesystem type 'LVM2_member'.
> > dmesg(1) may have more information after failed mount system call.
> > sed: /tmp/fw/EFI/fedora/grubenv kann nicht gelesen werden: Datei oder Verzeichnis nicht gefunden
> > DEBUT info:
> > /tmp/root/usr/share/uboot/rock-pi-4-rk3399
> > = No U-Boot files found for rock-pi-4-rk3399.
> >
> > = Installation Complete! Insert into the rock-pi-4-rk3399 and boot.
>
> The PREFIX is "/tmp/root" but should be empty.
>
> It is set in line 531 for IoT device and in line 533 adjusted for BTRFS (=Workstation). And for all others it is set in line with 535 to a value, which is wrong at least for Server and I guess all non-OStree and non-BTRFS editions.

Looking at the script, I don't think your diagnosis is quite right,
here.

What the script is trying to do is mount the target root filesystem to
/tmp/root , then do stuff to it. The prefix definitely *should* be
/tmp/root, otherwise it will be doing stuff to *the host system*, which
is not what we want.

Looking at your output, I think the problem in your case is rather that
mounting the target root filesystem on /tmp/root did not work. That's
what `mount: /tmp/root: unknown filesystem type 'LVM2_member'.` tells
us.

I suspect the problem may be here, in fact:
https://pagure.io/arm-image-installer/blob/main/f/arm-image-installer#_477
if you compare it to this later similar line:
https://pagure.io/arm-image-installer/blob/main/f/arm-image-installer#_511
it reads to me like the later block is the 'normal'/original path for
mounting /tmp/root, and the earlier block was kinda added later to
handle mounting earlier and resizing the filesystem in certain cases.
But it looks like on the earlier path we may try to mount the wrong
thing - $ROOTPART instead of /dev/$LVM_NAME/root .

This exact codepath is only hit when there is an LVM LV on the media
and the filesystem is xfs, which should be exactly the case for the
server image, I guess. (I am confused as to how the detection for both
those things somehow *works* in this case, but oh well).

I have quite a lot of other questions about how this script is written,
but, well...I think that's the problem :)
--
Adam Williamson (he/him/his)
Fedora QA
Fedora Chat: @adamwill:fedora.im | Mastodon: @adamw@fosstodon.org
https://www.happyassassin.net



_______________________________________________
arm mailing list -- arm@lists.fedoraproject.org
To unsubscribe send an email to arm-leave@lists.fedoraproject.org
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/arm@lists.fedoraproject.org
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue