Tuesday, February 18, 2014

[389-commits] include/base include/libaccess

include/base/ereport.h | 4 ++--
include/libaccess/aclerror.h | 10 ----------
include/libaccess/acleval.h | 3 +--
3 files changed, 3 insertions(+), 14 deletions(-)

New commits:
commit 16386dde80e62b3d45697b7538d84dcb4a09255a
Author: Noriko Hosoi <nhosoi@redhat.com>
Date: Tue Feb 18 15:28:54 2014 -0800

Ticket #47700 - Unresolved external symbol references break loading of the ACL plugin

Description of problem by nalin@redhat.com:
Various functions in the directory server are declared with extern "C"
linkage, causing the compiler to emit references to an unmangled symbol
name, but because their definitions don't match the declarations, and
the definitions are compiled using the C++ compiler, the implementations
are emitted as mangled symbols.

Fix description: Using ld option "-z defs", cleaned all the undefined
references.

https://fedorahosted.org/389/ticket/47700

Reviewed by rmeggins@redhat.com (Thank you, Rich!!)

diff --git a/include/base/ereport.h b/include/base/ereport.h
index 40813ea..e97be14 100644
--- a/include/base/ereport.h
+++ b/include/base/ereport.h
@@ -65,13 +65,13 @@ NSPR_BEGIN_EXTERN_C
* the current date.
*/

-NSAPI_PUBLIC int INTereport(int degree, const char *fmt, ...)
+NSAPI_PUBLIC int INTereport(int degree, char *fmt, ...)
#ifdef __GNUC__
__attribute__ ((format (printf, 2, 3)));
#else
;

No comments:

Post a Comment