Wednesday, June 12, 2019

[389-devel] Re: please review: Replication Status Message Improvements

Sorry Mark, my email was confusing.

First you make a good point. Giving extra info does not hurt.

I just noticed that replication status contains two RC (ldap and
replication), while init status contains three RC (ldap, replication,
connection). So the json struct should differ from regular_replication
and init_replication status.

On 6/12/19 6:17 PM, Mark Reynolds wrote:
>
> On 6/12/19 12:08 PM, thierry bordaz wrote:
>> Hi Mark,
>>
>> Looking very good to me.
>> For replication status there is either ldaprc or replrc. The message
>> is self explaining if it is a LDAP or replication error. IMHO I think
>> json could only contain 'repl_status' that can contain ldaprc or replrc.
> Well I was thinking it didn't hurt to have separate error code
> elements in the JSON object, and it allows a client to know what type
> of error it is without having to interpret the message string. This
> "could" be useful to an Admin which is why I added it.  Maybe its not
> that useful, but like I said I don't think it hurts.
>>
>> For init status, it exists ldaprc, connrc and replrc. I think it
>> would be good to have all three.
>
> Wait :-)  So now you want the error code object elements?
>
> Either way good point, the JSON object should have all three error
> code types (unless it is decided to remove all the error code elements).
>
> Thanks,
>
> Mark
>
>>
>> best regards
>> thierry
>>
>> On 6/12/19 5:36 PM, Mark Reynolds wrote:
>>> http://www.port389.org/docs/389ds/design/repl-agmt-status-design.html
>>> _______________________________________________
>>> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
>>> To unsubscribe send an email to 389-devel-leave@lists.fedoraproject.org
>>> Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
>>> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>>> List Archives:
>>> https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org
>> _______________________________________________
>> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
>> To unsubscribe send an email to 389-devel-leave@lists.fedoraproject.org
>> Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
>> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
>> List Archives:
>> https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org
_______________________________________________
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-leave@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/389-devel@lists.fedoraproject.org

No comments:

Post a Comment