Monday, June 23, 2014

[389-commits] ldap/servers

ldap/servers/slapd/operation.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)

New commits:
commit a1ab514c1db436015e7d601dcde0832f31b63452
Author: Ludwig Krispenz <lkrispen@redhat.com>
Date: Mon Jun 23 14:40:33 2014 +0200

fix coverity issue 12621

reviewd by Nathan, thanks

diff --git a/ldap/servers/slapd/operation.c b/ldap/servers/slapd/operation.c
index 1b45c3f..c31e8bc 100644
--- a/ldap/servers/slapd/operation.c
+++ b/ldap/servers/slapd/operation.c
@@ -632,8 +632,12 @@ slapi_connection_remove_operation( Slapi_PBlock *pb, Slapi_Connection *conn, Sla
for ( tmp = olist; *tmp != NULL && *tmp != op; tmp = &(*tmp)->o_next )
; /* NULL */
if ( *tmp == NULL ) {
- LDAPDebug( LDAP_DEBUG_ANY, "connection_remove_operation: can't find op %d for conn %" NSPRIu64 "\n",
- (int)op->o_msgid, conn->c_connid, 0 );
+ if (op) {
+ LDAPDebug( LDAP_DEBUG_ANY, "connection_remove_operation: can't find op %d for conn %" NSPRIu64 "\n",
+ (int)op->o_msgid, conn->c_connid, 0 );
+ } else {
+ LDAPDebug( LDAP_DEBUG_ANY, "connection_remove_operation: no operation provided\n");
+ }
} else {
*tmp = (*tmp)->o_next;
}


--
389 commits mailing list
389-commits@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-commits

No comments:

Post a Comment