Thursday, June 30, 2016

[389-commits] lib/libadminutil

lib/libadminutil/psetc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 3253bef42151cbef479a3a08e50066da0f60c952
Author: Mark Reynolds <mreynolds@redhat.com>
Date: Thu Jun 30 14:13:18 2016 -0400

Ticket 48345 - bad check for NUL char in psetc.c

Description: There was an improper check for a NUL string.

Fix provided by community member "dcb" - Thanks!

https://fedorahosted.org/389/ticket/48345

Reviewed by: mreynolds(one line commit rule)

diff --git a/lib/libadminutil/psetc.c b/lib/libadminutil/psetc.c
index 6a09638..3ab72d9 100644
--- a/lib/libadminutil/psetc.c
+++ b/lib/libadminutil/psetc.c
@@ -198,7 +198,7 @@ psetNodeLDAPDestroy(PsetNodePtr target, LDAP *ld)
}
}

- if (target->attrName && target->attrName != '\0') PR_Free(target->attrName);
+ if (target->attrName && *(target->attrName) != '\0') PR_Free(target->attrName);
if (target->ldapHolder) ldap_msgfree(target->ldapHolder);
if (target->attrFile) treeRemoveTree(target->attrFile);

--
389-commits mailing list
389-commits@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/389-commits@lists.fedoraproject.org

No comments:

Post a Comment