[389-devel] Re: Please review 48992: Total init may fail if the pushed schema is rejected

Hi Thierry,

the description in the commit is now fine, but given that the choice of
LDAP_CONSTRAINT_VIOLATION is a bit arbitrary it would be good to have a
comment where it is set, explaining why this error code was used.
About which error code to choose, if you have to pick one of the errors
which will allow "keep_going" it is fine, although I think the original
choice of unwilling to perform was a better match, operations_error or
ldap_other would, in my opinion, also be good candidates - but they are
in the wrong category.

Looking at ignore_error_and_keep_going, I am wondering if this partition
in go|stop is really still correct ? maybe we should investigate this as
well.

Ludwig

On 09/23/2016 10:08 AM, thierry bordaz wrote:
> Thanks Noriko for your review. I updated the patch to give more
> explanation why the fix is in modify_schema_dse.
> I pick up LDAP_CONSTRAINT_VIOLATION in replacement of
> UNWILLING_TO_PERFORM but I have not strong opinion on appropriate
> value of that returned value. In the logic of that fix, it just needs
> to be not fatal regarding ignore_error_and_keep_going.
>
> https://fedorahosted.org/389/attachment/ticket/48992/0002-Ticket-48992-Total-init-may-fail-if-the-pushed-schem.patch
>
>
> https://fedorahosted.org/389/ticket/48992
> _______________________________________________
> 389-devel mailing list -- 389-devel@lists.fedoraproject.org
> To unsubscribe send an email to 389-devel-leave@lists.fedoraproject.org

--
Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Michael Cunningham, Michael O'Neill, Eric Shander
_______________________________________________
389-devel mailing list -- 389-devel@lists.fedoraproject.org
To unsubscribe send an email to 389-devel-leave@lists.fedoraproject.org