Tuesday, May 30, 2017

[389-commits] [389-ds-base] 01/02: Ticket 49271 - Fix pbkdf2 and openssl missing issue

This is an automated email from the git hooks/post-receive script.

firstyear pushed a commit to branch master
in repository 389-ds-base.

commit e78dfe0f2faccd7f63ee5fad857b7518258ff751
Author: William Brown <firstyear@redhat.com>
Date: Mon May 29 12:12:39 2017 +1000

Ticket 49271 - Fix pbkdf2 and openssl missing issue

Bug Description: NSS 3.28 and lower don't support pbkdf2. If we are
on this version, don't run the tests. We never released this feature
for older rhel, so it only affects the test.

Fix Description: ifdef out the tests if NSS is too old.

https://pagure.io/389-ds-base/issue/49271

Author: wibrown

Review by: mreynolds (Thanks!)
---
test/plugins/pwdstorage/pbkdf2.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/test/plugins/pwdstorage/pbkdf2.c b/test/plugins/pwdstorage/pbkdf2.c
index 0193fbb..f2cc1b4 100644
--- a/test/plugins/pwdstorage/pbkdf2.c
+++ b/test/plugins/pwdstorage/pbkdf2.c
@@ -27,6 +27,7 @@ test_plugin_pwdstorage_nss_stop(void **state __attribute__((unused))) {
void
test_plugin_pwdstorage_pbkdf2_auth(void **state __attribute__((unused))) {

+#if (NSS_VMAJOR * 100 + NSS_VMINOR) > 328
/* Check that given various known passwords and hashes they validate (or don't) */

/* 'password' */
@@ -49,10 +50,12 @@ test_plugin_pwdstorage_pbkdf2_auth(void **state __attribute__((unused))) {
assert_false(pbkdf2_sha256_pw_cmp("password", password_a_rounds) == 0);
assert_false(pbkdf2_sha256_pw_cmp("password", password_a_salt) == 0);
assert_false(pbkdf2_sha256_pw_cmp("password_b", password_a) == 0);
+

No comments:

Post a Comment