Thursday, July 10, 2014

[389-commits] ldap/servers

ldap/servers/plugins/replication/repl5_agmt.c | 5 +++++
1 file changed, 5 insertions(+)

New commits:
commit a9b0d43102ee5ad3de2889cfb01bc452cd254848
Author: Ludwig Krispenz <lkrispen@redhat.com>
Date: Thu Jul 10 14:47:09 2014 +0200

Ticket 47846 - server crashes deleting a replication agreement

Bug Description: when an agreement is deleted the ruv in
the repl agreemnet object is cleaned.
But if the agrrement is disabled, the
object doesn't exist and attempt to access
it crashes

Fix Description: remove maxcsn only if protocol is started

https://fedorahosted.org/389/ticket/47846

Reviewed by: Rich, thanks

diff --git a/ldap/servers/plugins/replication/repl5_agmt.c b/ldap/servers/plugins/replication/repl5_agmt.c
index 9d617e7..7c5c37c 100644
--- a/ldap/servers/plugins/replication/repl5_agmt.c
+++ b/ldap/servers/plugins/replication/repl5_agmt.c
@@ -3032,6 +3032,11 @@ agmt_remove_maxcsn(Repl_Agmt *ra)
char *attrs[2];
int rc;

+ if (ra->protocol == NULL) {
+ /* nothing to do, agmt is not started */
+ return;
+ }
+
pb = slapi_pblock_new();
if (!pb) {
slapi_log_error(SLAPI_LOG_FATAL, repl_plugin_name, "agmt_set_maxcsn: Out of memory\n");


--
389 commits mailing list
389-commits@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-commits

No comments:

Post a Comment