Thursday, August 20, 2020

[389-commits] [389-ds-base] branch 389-ds-base-1.4.3 updated: Issue 51229 - Server Settings page gets into an unresponsive state

This is an automated email from the git hooks/post-receive script.

spichugi pushed a commit to branch 389-ds-base-1.4.3
in repository 389-ds-base.

The following commit(s) were added to refs/heads/389-ds-base-1.4.3 by this push:
new cd7b96f Issue 51229 - Server Settings page gets into an unresponsive state
cd7b96f is described below

commit cd7b96f21d2f1e40a299d6d5a1b88bc52196dff3
Author: Simon Pichugin <spichugi@redhat.com>
AuthorDate: Tue Aug 18 15:52:32 2020 +0200

Issue 51229 - Server Settings page gets into an unresponsive state

Bug Description: If we switch the tab in Cockpit UI and restart
the instance - we can't go back to the default tab as it's in
an unresponsive loading state.

Fix Description: Do the update on ComponentDidUpdate instead of
ComponentDidMount.

https://pagure.io/389-ds-base/issue/51229

Reviewed by: mreynolds (Thanks!)
---
src/cockpit/389-console/src/server.jsx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/cockpit/389-console/src/server.jsx b/src/cockpit/389-console/src/server.jsx
index 98cceb6..27193b7 100644
--- a/src/cockpit/389-console/src/server.jsx
+++ b/src/cockpit/389-console/src/server.jsx
@@ -35,7 +35,7 @@ export class Server extends React.Component {
this.selectNode = this.selectNode.bind(this);
}

- componentDidMount() {
+ componentDidUpdate() {
if (this.props.wasActiveList.includes(1)) {
if (this.state.firstLoad) {
this.loadConfig();

--
To stop receiving notification emails like this one, please contact
the administrator of this repository.
_______________________________________________
389-commits mailing list -- 389-commits@lists.fedoraproject.org
To unsubscribe send an email to 389-commits-leave@lists.fedoraproject.org
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/389-commits@lists.fedoraproject.org

No comments:

Post a Comment