[389-commits] ldap/servers

ldap/servers/slapd/back-ldbm/import.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit 13ec1d6de60ad69ed5c99f517e8b61ac540c2255
Author: Mark Reynolds <mreynolds@redhat.com>
Date: Wed Jul 2 11:40:20 2014 -0400

Ticket 47827 - Fix coverity issue 12695

Description: Fix coverity issue 12695 (Dereference before NULL check)

https://fedorahosted.org/389/ticket/47827

Reviewed by: rmeggins(Thanks!)

diff --git a/ldap/servers/slapd/back-ldbm/import.c b/ldap/servers/slapd/back-ldbm/import.c
index 3c195e2..45ea68a 100644
--- a/ldap/servers/slapd/back-ldbm/import.c
+++ b/ldap/servers/slapd/back-ldbm/import.c
@@ -217,11 +217,15 @@ static void import_task_destroy(Slapi_Task *task)
{
ImportJob *job = (ImportJob *)slapi_task_get_data(task);

+ if(!job){
+ return;
+ }
+
while(is_instance_busy(job->inst)){
/* wait for the job to finish before freeing it */
DS_Sleep(PR_SecondsToInterval(1));
}
- if (job && job->task_status) {
+ if (job->task_status) {
slapi_ch_free((void **)&job->task_status);
job->task_status = NULL;
}

--
389 commits mailing list
389-commits@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/389-commits